Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dimaMachina
left a comment
dimaMachina
left a comment
There was a problem hiding this comment.
i think all this was migrated but we didn't remove it.
|
Hold fire on this. |
|
Okay I dug up the bug with proseWrap in MDX / bug report. Yes, we must disable proseWrap in MDX if we enable prettier; generally I don't trust it with MDX files. I've taken to just un-ignoring each new MDX file I add - perhaps we should ignore certain problematic files but enable? |
|
@saihaj is it possible to generate the static website before and after this change and assert that there are no differences in the generated output? |
yes. The deploy preview we see on this PR is a version we can compare that with prod. We can build this branch and then try to |
|
If there's no differences in the generated output then I think it's safe to merge. I'm personally fine with the default of not enabling prettier on MDX files though, historically they've had a number of issues. |
3 participants
Not sure why we disabled prettier for
.mdxfiles. I was working on some other PR and saw it wasn't working so decided to enable for everything.